gh-128982: Revert "#128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative (GH-128983)" and add tests #130584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ejar.join_header_words` for an efficient alternative (pythonGH-128983)" This reverts commit 56e1900.
|
Sorry! I had a branch mixup, these are indeed failing on |
|
I'm glad I'm not the only confused reviewer today ^^; |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
… in http.cookiejar.join_header_words for an efficient alternative (pythonGH-128983)" and add tests (pythonGH-130584) * Revert "pythongh-128982: Substitute regular expression in `http.cookiejar.join_header_words` for an efficient alternative (pythonGH-128983)" This reverts commit 56e1900. * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "#128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative (GH-128983)"
This reverts commit 56e1900.
Add additional tests.
http.cookiejar.join_header_words#128982