Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 2, 2025

(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das [email protected]


📚 Documentation preview 📚: https://cpython-previews--130759.org.readthedocs.build/

(cherry picked from commit 37145cb)

Co-authored-by: Arijit Kumar Das <[email protected]>
@ghost
Copy link

ghost commented Mar 2, 2025

All commit authors signed the Contributor License Agreement.
CLA signed

@picnixz
Copy link
Member

picnixz commented Mar 2, 2025

@hugovk That's weird, the CLA was signed on the original PR. What happened here?

@hugovk
Copy link
Member

hugovk commented Mar 2, 2025

I think it's because the user probably has a gmail.com email in their GitHub account (used for #130741) and signed the CLA with that, but has a different outlook.com email in the commit used here: https://github.com/python/cpython/pull/130759.patch

@picnixz
Copy link
Member

picnixz commented Mar 2, 2025

So, IIUC, we have a commit whose CLA that is signed with a different email than the commit's email. Since we already merged that commit in main, can we assume that the CLA was properly signed? (can you unsign the CLA?)

@hugovk
Copy link
Member

hugovk commented Mar 2, 2025

Probably, but the CLA bot is a required status check. The easiest thing is for the contributor to also sign the CLA with the other email. (Another option is to amend the commit in the backport and force push.)

@ArijitKD Please could you also sign the CLA with your outlook.com email address? See #130759 (comment).

@ArijitKD
Copy link
Contributor

ArijitKD commented Mar 2, 2025

@hugovk CLA signed. That outlook.com is actually not the email I use for github commits. Probably got swapped somehow. Anyways, this is ready to be merged now!

@hugovk
Copy link
Member

hugovk commented Mar 2, 2025

Thank you!

@hugovk hugovk merged commit 9854566 into python:3.13 Mar 2, 2025
29 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants