-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-124269: Simplify typing.Annotated docs
#130770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I forgot about this one. If Jelle approves the PR today, go ahead and merge it, or I'll review it tomorrow. |
Co-authored-by: Jelle Zijlstra <[email protected]>
@picnixz friendly ping :-) |
|
I'm currently travelling so I don't have time to review sorry. Nikita/Alex could also review the PR but I trust Jelle's judgment on this one so if he wants to merge it, go ahead. I can review it when I'm at the airport in a few hours though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unusure whether the import are actually needed because the current code has from typing import Annotated, get_origin and then a different doctest block for get_origin(Password) so I don't know if they're correctly being tested. Apparently, yes though.
Co-authored-by: Bénédikt Tran <[email protected]>
|
Thanks @StanFromIreland for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
--------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-131222 is a backport of this pull request to the 3.13 branch. |
--------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-131223 is a backport of this pull request to the 3.12 branch. |
gh-124269: Simplify `typing.Annotated` docs (GH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
gh-124269: Simplify `typing.Annotated` docs (GH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
…0770) (python#131223) pythongh-124269: Simplify `typing.Annotated` docs (pythonGH-130770) --------- (cherry picked from commit e4ac196) Co-authored-by: Stan Ulbrych <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
--------- Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
--------- Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
Grouped relevant bullet points into paragraphs. Maybe I took too many creative liberties...
Request: @JelleZijlstra @sobolevn @picnixz
typing.Annotateddocs #124269