Skip to content

gh-128041: Try to fix transiency of test_force_shutdown_workers #130812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-128041: Try to fix transiency of test_force_shutdown_workers #130812

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89c355a
Try to fix transiency of test_force_shutdown_workers
csm10495 Mar 3, 2025
94011b3
Merge branch 'main' into shutdown-workers-transiency
csm10495 Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions Lib/test/test_concurrent_futures/test_process_pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,15 +270,18 @@ def test_force_shutdown_workers(self, function_name):
self.assertEqual(q.get(timeout=5), 'started')

worker_process = list(executor._processes.values())[0]

Mock = unittest.mock.Mock
worker_process.terminate = Mock(wraps=worker_process.terminate)
worker_process.kill = Mock(wraps=worker_process.kill)

getattr(executor, function_name)()
worker_process.join()

if function_name == TERMINATE_WORKERS or \
sys.platform == 'win32':
# On windows, kill and terminate both send SIGTERM
self.assertEqual(worker_process.exitcode, -signal.SIGTERM)
if function_name == TERMINATE_WORKERS:
worker_process.terminate.assert_called()
elif function_name == KILL_WORKERS:
self.assertEqual(worker_process.exitcode, -signal.SIGKILL)
worker_process.kill.assert_called()
else:
self.fail(f"Unknown operation: {function_name}")

Expand Down
Loading