Skip to content

gh-130396: Fix thread sanitizer crashes on stack overflow tests #130966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

gh-130396: Fix thread sanitizer crashes on stack overflow tests #130966

merged 1 commit into from
Mar 11, 2025
+5 −0

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 7, 2025 •
edited by bedevere-app bot
Loading

Thread sanitizer will often crash if a test uses more than half the stack.

@colesbury
pythongh-130396: Fix thread sanitizer crashes on stack overflow tests
5dadae5 
Thread sanitizer will often crash if a test uses more than half the
stack.
@colesbury colesbury requested a review from mpage March 7, 2025 21:53
@colesbury colesbury requested a review from markshannon as a code owner March 7, 2025 21:53
@bedevere-app bedevere-app bot mentioned this pull request Mar 7, 2025
Open
@colesbury
Copy link
Contributor Author

For example the following previously crashed with SIGBUS on exit, but works with the PR:

./python -m test -u cpu test_descr -m test_wrapper_segfault -v

I tested with reduce stack sizes as well (ulimit -s 4096 and ulimit -s 2048).

mpage
mpage approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury merged commit 4162bc1 into python:main Mar 11, 2025
54 checks passed
@colesbury colesbury deleted the gh-130396-tsan-crash branch March 11, 2025 14:33
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@colesbury @seehwan80
pythongh-130396: Fix thread sanitizer crashes on stack overflow tests (…
650064f 
…pythongh-130966)

Thread sanitizer will often crash if a test uses more than half the
stack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury @mpage