- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
gh-131002: clarify how to enforce sqlite3 column types for generated fields #131006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            erlend-aasland
  merged 7 commits into
  python:main
from
erlend-aasland:sqlite/doc-parse-types-for-generated-fields
  
      
      
   
  Mar 17, 2025 
      
    
                
     Merged
            
            gh-131002: clarify how to enforce sqlite3 column types for generated fields #131006
                    erlend-aasland
  merged 7 commits into
  python:main
from
erlend-aasland:sqlite/doc-parse-types-for-generated-fields
  
      
      
   
  Mar 17, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    erlend-aasland
  
              
              commented
              
                  
                    Mar 9, 2025 
                  
              
              
            
            
              
                    erlend-aasland
  
              
              commented
              
                  
                    Mar 9, 2025 
                  
              
              
            
            
              
                    DLu
  
              
              approved these changes
              
                  
                    Mar 9, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
              
                    picnixz
  
              
              reviewed
              
                  
                    Mar 12, 2025 
                  
              
              
            
            
Co-authored-by: Bénédikt Tran <[email protected]>
              
                    erlend-aasland
  
              
              commented
              
                  
                    Mar 17, 2025 
                  
              
              
            
            
              
                    picnixz
  
              
              approved these changes
              
                  
                    Mar 17, 2025 
                  
              
              
            
            
| Thanks for the reviews! | 
      
        
              This comment was marked as outdated.
        
        
      
    
  This comment was marked as outdated.
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Mar 17, 2025 
    
    
      
  
    
      
    
  
…rated fields (pythonGH-131006) (cherry picked from commit f48887f) Co-authored-by: Erlend E. Aasland <[email protected]>
| GH-131385 is a backport of this pull request to the 3.13 branch. | 
    
  miss-islington 
      pushed a commit
        to miss-islington/cpython
      that referenced
      this pull request
    
      Mar 17, 2025 
    
    
      
  
    
      
    
  
…rated fields (pythonGH-131006) (cherry picked from commit f48887f) Co-authored-by: Erlend E. Aasland <[email protected]>
| GH-131386 is a backport of this pull request to the 3.12 branch. | 
    
  erlend-aasland 
      added a commit
      that referenced
      this pull request
    
      Mar 18, 2025 
    
    
      
  
    
      
    
  
…erated fields (GH-131006) (#131385) (cherry picked from commit f48887f) Co-authored-by: Erlend E. Aasland <[email protected]>
    
  erlend-aasland 
      added a commit
      that referenced
      this pull request
    
      Mar 18, 2025 
    
    
      
  
    
      
    
  
…erated fields (GH-131006) (#131386) (cherry picked from commit f48887f) Co-authored-by: Erlend E. Aasland <[email protected]>
    
  colesbury 
      pushed a commit
        to colesbury/cpython
      that referenced
      this pull request
    
      Mar 20, 2025 
    
    
  
    
  seehwan 
      pushed a commit
        to seehwan/cpython
      that referenced
      this pull request
    
      Apr 16, 2025 
    
    
  
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
PARSE_DECLTYPESandPARSE_COLNAMESdoc entries soPARSE_DECLTYPEScomes first, as its example introduces the example SQL table📚 Documentation preview 📚: https://cpython-previews--131006.org.readthedocs.build/