gh-131082: Add missing guards for WIN32_LEAN_AND_MEAN #131044
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
reviewed
Mar 11, 2025
Please open an issue. I would like to backport this fix to 3.12 and 3.13, having an issue helps tracking backports. |
vstinner
added
skip news
needs backport to 3.12
maxbachmann
changed the title
|
I opened an issue and added the whitespaces for readability |
|
Thanks @maxbachmann for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 11, 2025
…-131044) * Add missing guards for WIN32_LEAN_AND_MEAN * add missing whitespaces (cherry picked from commit de8818a) Co-authored-by: Max Bachmann <[email protected]>
|
Sorry, @maxbachmann and @vstinner, I could not cleanly backport this to |
|
GH-131084 is a backport of this pull request to the 3.13 branch. |
|
GH-131085 is a backport of this pull request to the 3.12 branch. |
|
Merged, thank you. I created backports. |
vstinner
added a commit
that referenced
this pull request
Mar 11, 2025
vstinner
pushed a commit
that referenced
this pull request
Mar 11, 2025
…) (#131084) (cherry picked from commit de8818a) Co-authored-by: Max Bachmann <[email protected]>
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…31044) * Add missing guards for WIN32_LEAN_AND_MEAN * add missing whitespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds missing guards for the WIN32_LEAN_AND_MEAN macro. I am working on the xbox where the toolchain already adds this definition. This leads to warnings about the macro getting redefined.
I think this should be trivial enough to require no issue / news entry