Skip to content

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Mar 10, 2025

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner enabled auto-merge (squash) March 12, 2025 07:49
@vstinner vstinner merged commit 155c44b into python:main Mar 12, 2025
46 checks passed
@StanFromIreland StanFromIreland deleted the time-sleep branch March 12, 2025 08:22
@picnixz
Copy link
Member

picnixz commented Mar 12, 2025

Question: Shouldn't we have a what's new entry since we changed the error message? If not, I'll close the issue; if so, we can keep it open for the additional what's new entry.

@vstinner
Copy link
Member

Question: Shouldn't we have a what's new entry since we changed the error message? If not, I'll close the issue; if so, we can keep it open for the additional what's new entry.

Usually we don't document changed error messages in Changelog nor in "What's New in Python 3.x" documents.

I closed the issue.

@picnixz
Copy link
Member

picnixz commented Mar 12, 2025

Usually we don't document changed error messages in Changelog nor in "What's New in Python 3.x" documents.

Ah right, we actually had quite a lot of "improve error message of [...]" in the changelog but not in What's New (only error messages that were "important" were actually put there)

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants