gh-131123: Support completion in pdb for convenience variable attributes
#131124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
pdb for convenience variable attributes
picnixz
reviewed
Mar 12, 2025
picnixz
approved these changes
Mar 12, 2025
iritkatriel
reviewed
Mar 12, 2025
| else: | ||
| if text.startswith("$"): | ||
| # Complete convenience variables | ||
| conv_vars = self.curframe.f_globals.get('__pdb_convenience_variables', {}) |
There was a problem hiding this comment.
Here you use get and in line 985 you don't. Is that correct?
There was a problem hiding this comment.
line 985 is in a try block which has a KeyError catch. If the first part starts with $ and does not exist in globals, we should just return []. That's also how it handles the other parts.
iritkatriel
approved these changes
Mar 12, 2025
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pdbfor convenience variables #131123