gh-131094: Refine math.isclose docs #131139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the statement about any *x* and *rel_tol* always producing ``False`` to exclude ``x = 0``.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
skirpichev
approved these changes
Mar 12, 2025
picnixz
approved these changes
Mar 17, 2025
picnixz
added
needs backport to 3.12
|
Thanks @guyjacoby for the PR, and @picnixz for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2025
(cherry picked from commit 3f50f96) Co-authored-by: Guy Jacoby <[email protected]>
|
GH-131392 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 18, 2025
(cherry picked from commit 3f50f96) Co-authored-by: Guy Jacoby <[email protected]>
|
GH-131393 is a backport of this pull request to the 3.12 branch. |
colesbury
pushed a commit
to colesbury/cpython
that referenced
this pull request
Mar 20, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected the statement about any x and rel_tol always producing
Falseto excludex = 0.math.isclose(0, x)whenx = 0#131094📚 Documentation preview 📚: https://cpython-previews--131139.org.readthedocs.build/