gh-131170: fix duplicated sections in frames.md file #131177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the frames.md file at InternalDocs, change the first duplicated title to Specials, and remove unnecessary content under the Specials section.
bedevere-app
bot
added
docs
|
All commit authors signed the Contributor License Agreement. |
picnixz
reviewed
Mar 13, 2025
| @@ -0,0 +1,2 @@ | |||
| The duplication of titles in the frames.md file at InternalDocs has been | |||
There was a problem hiding this comment.
No need for a NEWS entry as it's internal documentation and not exposed documentation.
There was a problem hiding this comment.
Thank you. However, it would be a good idea to add this comment as a note in the devguide, specifically in the quick reference at step 8. 👍🏻
There was a problem hiding this comment.
Do you mean, the fact that it's an internal-only?
There was a problem hiding this comment.
I guess it doesn't hurt to specify when a NEWS entry is really needed. Thanks for the feedback!
nybblista
force-pushed
the
fix-issue-131170
branch
from
3200efd to
99d7808
Compare
picnixz
approved these changes
Mar 13, 2025
|
I was planning to merge it after eating something but you beat me to it! |
|
In fact, I was eating while merging 🥘 |
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…1177) fix duplicated sections in frames.md file In the frames.md file at InternalDocs, change the first duplicated title to Specials, and remove unnecessary content under the Specials section.
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…1177) fix duplicated sections in frames.md file In the frames.md file at InternalDocs, change the first duplicated title to Specials, and remove unnecessary content under the Specials section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "frames.md" file at InternalDocs, I have changed the first duplicated title to Specials and removed the unnecessary content under the Specials section.
InternalDocs/frames.md#131170