Skip to content

GH-129149: Add fast paths to four more PyLong_From* functions #131211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 30, 2025
Merged

GH-129149: Add fast paths to four more PyLong_From* functions #131211

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d335b11
use the PYLONG_FROM_*INT macros in more
chris-eibl Mar 13, 2025
166ee39
blurb it
chris-eibl Mar 13, 2025
3305d9b
small ints have a fast path, too
chris-eibl Mar 13, 2025
9947a4e
PEP-7
chris-eibl Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Core_and_Builtins/2025-03-13-20-23-02.gh-issue-129149.z42wkm.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Add fast path for small and medium-size integers in
:c:func:`PyLong_FromInt32`, :c:func:`PyLong_FromUInt32`,
:c:func:`PyLong_FromInt64` and
:c:func:`PyLong_FromUInt64`. Patch by Chris Eibl.
20 changes: 12 additions & 8 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6741,17 +6741,21 @@ PyUnstable_Long_CompactValue(const PyLongObject* op) {
}


PyObject* PyLong_FromInt32(int32_t value)
{ return PyLong_FromNativeBytes(&value, sizeof(value), -1); }
PyObject* PyLong_FromInt32(int32_t value) {
PYLONG_FROM_INT(uint32_t, int32_t, value);
}

PyObject* PyLong_FromUInt32(uint32_t value)
{ return PyLong_FromUnsignedNativeBytes(&value, sizeof(value), -1); }
PyObject* PyLong_FromUInt32(uint32_t value) {
PYLONG_FROM_UINT(uint32_t, value);
}

PyObject* PyLong_FromInt64(int64_t value)
{ return PyLong_FromNativeBytes(&value, sizeof(value), -1); }
PyObject* PyLong_FromInt64(int64_t value) {
PYLONG_FROM_INT(uint64_t, int64_t, value);
}

PyObject* PyLong_FromUInt64(uint64_t value)
{ return PyLong_FromUnsignedNativeBytes(&value, sizeof(value), -1); }
PyObject* PyLong_FromUInt64(uint64_t value) {
PYLONG_FROM_UINT(uint64_t, value);
}

#define LONG_TO_INT(obj, value, type_name) \
do { \
Expand Down
Loading