Skip to content

gh-131219: Improve tests in test_lzma.py by adding more asserts #131220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 14, 2025
Merged

gh-131219: Improve tests in test_lzma.py by adding more asserts #131220

merged 2 commits into from
Mar 14, 2025

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Mar 14, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn added tests Tests in the Lib/test dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 14, 2025
@sobolevn sobolevn requested a review from picnixz March 14, 2025 09:12
@bedevere-app bedevere-app bot mentioned this pull request Mar 14, 2025
Closed
picnixz
picnixz reviewed Mar 14, 2025
View reviewed changes
@sobolevn
Copy link
Member Author

I reported the hypothesis failure: #131229

@sobolevn sobolevn enabled auto-merge (squash) March 14, 2025 10:09
@sobolevn sobolevn merged commit f6c24a5 into python:main Mar 14, 2025
41 of 42 checks passed
@miss-islington-app
Copy link

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 14, 2025
@sobolevn @miss-islington
pythongh-131219: Improve tests in test_lzma.py by adding more asser…
d0227f8 
…ts (pythonGH-131220)

(cherry picked from commit f6c24a5)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 14, 2025

GH-131231 is a backport of this pull request to the 3.13 branch.

@miss-islington-app
Copy link

Sorry, @sobolevn, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker f6c24a5c89a1f08d583ab7f4d5c6751223f8e280 3.12

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 14, 2025
sobolevn added a commit that referenced this pull request Mar 14, 2025
@miss-islington @sobolevn
[3.13] gh-131219: Improve tests in test_lzma.py by adding more asse…
7d498aa 
…rts (GH-131220) (#131231)

gh-131219: Improve tests in `test_lzma.py` by adding more asserts (GH-131220)
(cherry picked from commit f6c24a5)

Co-authored-by: sobolevn <[email protected]>
sobolevn added a commit to sobolevn/cpython that referenced this pull request Mar 14, 2025
@sobolevn
[3.12] pythongh-131219: Improve tests in test_lzma.py by adding mor…
29db7f0 
…e asserts (pythonGH-131220)

(cherry picked from commit f6c24a5)

Co-authored-by: sobolevn <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Mar 14, 2025

GH-131237 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 14, 2025
sobolevn added a commit that referenced this pull request Mar 14, 2025
@sobolevn
[3.12] gh-131219: Improve tests in test_lzma.py by adding more asse…
6658ada 
…rts (GH-131220) (#131237)

Co-authored-by: sobolevn <[email protected]>
mikec9 pushed a commit to mikec9/cpython that referenced this pull request Mar 14, 2025
@sobolevn
[3.12] pythongh-131219: Improve tests in test_lzma.py by adding mor…
f458a8a 
…e asserts (pythonGH-131220) (python#131237)

Co-authored-by: sobolevn <[email protected]>
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@sobolevn @plashchynski
pythongh-131219: Improve tests in test_lzma.py by adding more asser…
d3c2603 
…ts (python#131220)
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@sobolevn @seehwan80
pythongh-131219: Improve tests in test_lzma.py by adding more asser…
cbbe581 
…ts (python#131220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Assignees

@sobolevn sobolevn

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sobolevn @picnixz