Skip to content

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 15, 2025

Fix

1>..\Modules\blake2module.c(77,9): warning : variable 'eax1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(77,19): warning : variable 'ebx1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,9): warning : variable 'eax7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,29): warning : variable 'ecx7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,39): warning : variable 'edx7' set but not used [-Wunused-but-set-variable]

we see them two (non-PGO) or three times, because the _freeze_module compiles blake2module.c, too.

I think this is a skip news.

edx7 = info7[3];
#else
#endif
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL... definitely fighting against the compiler's idea of best practices here using useless no-op statements as a way to work around it. i wish we could disable a specific warning for a whole block of code. i feel like a future compiler will notice that these are useless and stop considering them a "use".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just the least minimal change to silence the warning :)

Luckily, I think we'll never have to fear that this will ever need a change: that (void) pattern is adapted by all known compilers for ages - and I think this will stay.

@gpshead gpshead merged commit faa80fc into python:main Mar 15, 2025
49 checks passed
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would have used (void) ... in the elif branch but it would be an overkill for foolish consistency.

(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;
(void) eax7; (void) ebx7; (void) ecx7; (void) edx7;
#endif

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the double blank lines L98/L99 please? TiA

@picnixz
Copy link
Member

picnixz commented Mar 15, 2025

Oh it was merged :')

@chris-eibl chris-eibl deleted the fix_clangcl_blake2module branch March 15, 2025 19:18
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
…ython#131299)

work around unimportant clang-cl warnings in blake2module.c
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
…ython#131299)

work around unimportant clang-cl warnings in blake2module.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants