Skip to content

GH-131296: clang-cl on Windows: fix unused warning "self" in fileio.c #131303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

GH-131296: clang-cl on Windows: fix unused warning "self" in fileio.c #131303

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3b67fc
fix unused warning "self" in fileio.c
chris-eibl Mar 15, 2025
e0e2d27
fix * position
chris-eibl Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Modules/_io/fileio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1293,8 +1293,8 @@ fileio_get_mode(PyObject *op, void *closure)
static PyObject *
fileio_get_blksize(PyObject *op, void *closure)
{
fileio *self = PyFileIO_CAST(op);
#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE
fileio* self = PyFileIO_CAST(op);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the * position accidentally became inconsistent in this file, which could be unfriendly with some editors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot!

Viusal Studio thinks it does me a favor when copy pasting -> it reformats :(

Now I found that evil setting and disabled it!

if (self->stat_atopen != NULL && self->stat_atopen->st_blksize > 1) {
return PyLong_FromLong(self->stat_atopen->st_blksize);
}
Expand Down
Loading