Skip to content

GH-131296: fix clang-cl warnings in sysmodule.c #131304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2025
Merged

GH-131296: fix clang-cl warnings in sysmodule.c #131304

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0eea635
fix clang-cl warnings in sysmodule.c
chris-eibl Mar 15, 2025
e13019c
Merge branch 'main' into fix_clangcl_sysmodule
chris-eibl Mar 20, 2025
ab05290
add the additional empty line again
chris-eibl Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Python/sysmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,7 @@ sys_getrecursionlimit_impl(PyObject *module)

#ifdef MS_WINDOWS

static PyTypeObject WindowsVersionType = {0, 0, 0, 0, 0, 0};
static PyTypeObject WindowsVersionType = { 0 };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, this generated 3 times

warning : suggest braces around initialization of subobject [-Wmissing-braces]

Doubled/or trippled, because compiled in the _freeze_module, too.


static PyStructSequence_Field windows_version_fields[] = {
{"major", "Major version number"},
Expand Down Expand Up @@ -2527,8 +2527,9 @@ sys__is_gil_enabled_impl(PyObject *module)
#endif
}


#ifndef MS_WINDOWS
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix warning : unused variable 'perf_map_state' [-Wunused-variable]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was fixed by 486d537, you can now revert the change which just removes an empty line, no?

static PerfMapState perf_map_state;
#endif

PyAPI_FUNC(int) PyUnstable_PerfMapState_Init(void) {
#ifndef MS_WINDOWS
Expand Down
Loading