Skip to content

gh-131421: fix ASDL grammar for Dict to have an expr?* keys field #131419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 4, 2025
Merged

gh-131421: fix ASDL grammar for Dict to have an expr?* keys field #131419

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dcc5610
Python.asdl: Fix `Dict` variant to have an `expr?*` keys field.
Demonstrandum Mar 18, 2025
2a19020
Update Parser/asdl.py to parse multiple chained quantifiers.
Demonstrandum Mar 18, 2025
cbccd92
Remove newline before return.
Demonstrandum Mar 18, 2025
da764a3
enum
JelleZijlstra May 4, 2025
9406ddb
Merge remote-tracking branch 'upstream/main' into Demonstrandum/main
JelleZijlstra May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parser/Python.asdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ module Python
| UnaryOp(unaryop op, expr operand)
| Lambda(arguments args, expr body)
| IfExp(expr test, expr body, expr orelse)
| Dict(expr* keys, expr* values)
| Dict(expr?* keys, expr* values)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change makes me wonder whether we should also add '+' to indicate 1 or more items. For instance nonlocal requires at least one name, same for import, global and others.

Similarly, there is no explanation of what * and ? actually mean. While they can be inferred, I would expect a caption for them. WDYT @JelleZijlstra?

| Set(expr* elts)
| ListComp(expr elt, comprehension* generators)
| SetComp(expr elt, comprehension* generators)
Expand Down
Loading