gh-131457: Fix typo in BNF description of function signatures #131460

srinivasreddy · 2025-03-19T14:16:34Z

Issue: Typo in BNF description of function signatures #131457

📚 Documentation preview 📚: https://cpython-previews--131460.org.readthedocs.build/

sobolevn

Thank you!

miss-islington-app · 2025-03-22T07:54:52Z

Thanks @srinivasreddy for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

…ythonGH-131460) (cherry picked from commit 8b7d20d) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <[email protected]>

bedevere-app · 2025-03-22T07:55:12Z

GH-131575 is a backport of this pull request to the 3.13 branch.

…ythonGH-131460) (cherry picked from commit 8b7d20d) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <[email protected]>

bedevere-app · 2025-03-22T07:55:18Z

GH-131576 is a backport of this pull request to the 3.12 branch.

…H-131460) (#131575) gh-131457: Fix typo in BNF description of function signatures (GH-131460) (cherry picked from commit 8b7d20d) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <[email protected]>

…H-131460) (#131576) gh-131457: Fix typo in BNF description of function signatures (GH-131460) (cherry picked from commit 8b7d20d) Co-authored-by: Srinivas Reddy Thatiparthy (తాటిపర్తి శ్రీనివాస్ రెడ్డి) <[email protected]>

bedevere-bot · 2025-03-22T09:34:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Refleaks 3.13 (tier-2) has failed when building commit eedaa4e.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1512/builds/447) and take a look at the build logs.
Check if the failure is related to this commit (eedaa4e) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1512/builds/447

Failed tests:

test_perf_profiler

Failed subtests:

test_python_calls_appear_in_the_stack_if_perf_activated - test.test_perf_profiler.TestPerfProfilerWithDwarf.test_python_calls_appear_in_the_stack_if_perf_activated
test_timerfd_ns_TFD_TIMER_ABSTIME - test.test_os.TimerfdTests.test_timerfd_ns_TFD_TIMER_ABSTIME

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_os.py", line 4424, in test_timerfd_ns_TFD_TIMER_ABSTIME
    self.assertLess(abs(next_expiration_ns - offset_ns),  limit_error)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 2403248 not less than 1000000


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python_3booj368/tmp1aj8pe2l/perftest.py' not found in 'python 2259068 1495498.669148:          1 cycles:Pu: \n\t    ffff7fc28ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2259068 1495498.669169:          1 cycles:Pu: \n\tffffc95efcdffc78 [unknown] ([unknown])\n\tffffc95efce0049c [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffff7fc28ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2259068 1495498.670079:          1 cycles:Pu: \n\t          50aed4 read32+0x10 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          50bb27 chacha_init+0x5f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51e663 mi_random_init_ex+0x7f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51e67f _mi_random_init+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51e78b mi_heap_main_init+0x3f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          521557 mi_process_load+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          52160b _mi_process_init+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff7f9b63b7 call_init+0x117 (inlined)\n\t    ffff7f9b63b7 __libc_start_main@GLIBC_2.17+0x117 (inlined)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2259068 1495498.670097:        362 cycles:Pu: \n\t          512ee0 _mi_heap_random_next+0x0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          51e793 mi_heap_main_init+0x47 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          52


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/Lib/test/test_perf_profiler.py", line 356, in test_python_calls_appear_in_the_stack_if_perf_activated
    self.assertIn(f"py::foo:{script}", stdout)
    ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'py::foo:/tmp/test_python__lv6ng25/tmpk4mppxuy/perftest.py' not found in 'python 2364330 1496362.178801:          1 cycles:Pu: \n\t    ffff870d2ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2364330 1496362.178822:          1 cycles:Pu: \n\tffffc95efcdffc78 [unknown] ([unknown])\n\tffffc95efce0049c [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffff870d2ac0 _start+0x0 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2364330 1496362.179058:          1 cycles:Pu: \n\tffffc95efcdfff10 [unknown] ([unknown])\n\tffffc95efce004cc [unknown] ([unknown])\n\tffffc95efb9a15e4 [unknown] ([unknown])\n\t    ffff870d4628 <invalid>+0x28 (inlined)\n\t    ffff870d4628 mmap64+0x28 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870beabb <invalid>+0xddb (inlined)\n\t    ffff870beabb <invalid>+0xddb (inlined)\n\t    ffff870beabb _dl_map_object_from_fd+0xddb (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870bf133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870ba5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870b9303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870bab33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870d019f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870cd5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870ceb17 _dl_start_final+0x5ab (inlined)\n\t    ffff870ceb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870d2ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2364330 1496362.179103:        308 cycles:Pu: \n\t    ffff870beca8 <invalid>+0xfc8 (inlined)\n\t    ffff870beca8 <invalid>+0xfc8 (inlined)\n\t    ffff870beca8 _dl_map_object_from_fd+0xfc8 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870bf133 _dl_map_object+0x1e7 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870ba5bf openaux+0x3f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870b9303 _dl_catch_exception+0x63 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870bab33 _dl_map_object_deps+0x553 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870d019f dl_main+0x139f (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870cd5ff _dl_sysdep_start+0x1df (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870ceb17 _dl_start_final+0x5ab (inlined)\n\t    ffff870ceb17 _dl_start+0x5ab (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870d2ad3 _start+0x13 (/usr/lib/ld-linux-aarch64.so.1)\n\npython 2364330 1496362.180079:       1915 cycles:Pu: \n\t    ffff86e6fca0 __gconv_lookup_cache+0x0 (/usr/lib64/libc.so.6)\n\t    ffff86e67dc3 __gconv_find_transform+0x83 (/usr/lib64/libc.so.6)\n\t    ffff86eee72f __wcsmbs_getfct+0x14f (inlined)\n\t    ffff86eee72f __wcsmbs_load_conv+0x14f (/usr/lib64/libc.so.6)\n\t    ffff86eeced3 get_gconv_fcts+0x2b3 (inlined)\n\t    ffff86eeced3 __mbsrtowcs_l+0x2b3 (/usr/lib64/libc.so.6)\n\t    ffff86e7fe77 mbstowcs+0x37 (/usr/lib64/libc.so.6)\n\t          685923 _Py_mbstowcs
t/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b347 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff86e6625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff86e6633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2364330 1496362.180139:      49062 cycles:Pu: \n\t    ffff870bffd0 do_lookup_x+0x350 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870c0833 _dl_lookup_symbol_x+0x113 (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870c5a5b _dl_fixup+0xfb (/usr/lib/ld-linux-aarch64.so.1)\n\t    ffff870c7ef7 _dl_runtime_resolve+0x47 (/usr/lib/ld-linux-aarch64.so.1)\n\t          651577 _Py_get_xoption+0x73 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          651577 _Py_get_xoption+0x73 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2364330 1496362.181212:     106374 cycles:Pu: \n\t          58eb2c PyUnicode_InternFromString+0x0 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4bb55b descr_new+0x3f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4bc73f PyDescr_NewWrapper+0x2b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a4ff add_operators+0x63 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          53a877 type_ready_fill_dict+0x13 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          5476cf type_ready+0x93 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          547863 init_static_type+0xab (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          547a43 _PyStaticType_InitBuiltin+0x23 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          507797 _PyTypes_InitTypes+0xa7 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653133 pycore_init_types+0x1b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65374b pycore_interp_init+0x10b (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          653947 pyinit_config+0xaf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65afbf pyinit_core+0xdb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          65b097 Py_InitializeFromConfig+0x97 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b1ef pymain_init+0xff (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b2b3 pymain_main+0xf (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          68b347 Py_BytesMain+0x27 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          41ddb7 main+0xb (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t    ffff86e6625b __libc_start_call_main+0x7b (/usr/lib64/libc.so.6)\n\t    ffff86e6633b __libc_start_main@GLIBC_2.17+0x9b (inlined)\n\t          41dcaf _start+0x2f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\npython 2364330 1496362.182294:    2114724 cycles:Pu: \n\t          4f0adc _PyDict_CheckConsistency+0x88 (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f557f dict_setdefault_ref_lock_held+0x32f (/home/buildbot/buildarea/3.13.cstratak-fedora-stable-aarch64.refleak/build/python)\n\t          4f570b PyDict_SetDefaultRef+0x

…ython#131460)

pythongh-131457: Fix typo in BNF description of function signatures

0641ed1

srinivasreddy requested review from AA-Turner and willingc as code owners March 19, 2025 14:16

bedevere-app bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 19, 2025

github-project-automation bot added this to Docs PRs Mar 19, 2025

github-project-automation bot moved this to Todo in Docs PRs Mar 19, 2025

bedevere-app bot mentioned this pull request Mar 19, 2025

Typo in BNF description of function signatures #131457

Closed

sobolevn approved these changes Mar 22, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting review labels Mar 22, 2025

sobolevn added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 22, 2025

sobolevn merged commit 8b7d20d into python:main Mar 22, 2025
39 checks passed

github-project-automation bot moved this from Todo to Done in Docs PRs Mar 22, 2025

bedevere-app bot removed the awaiting merge label Mar 22, 2025

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 22, 2025

bedevere-app bot removed the needs backport to 3.12 only security fixes label Mar 22, 2025

seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025

pythongh-131457: Fix typo in BNF description of function signatures (p…

6840115

…ython#131460)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

gh-131457: Fix typo in BNF description of function signatures #131460

gh-131457: Fix typo in BNF description of function signatures #131460

Uh oh!

srinivasreddy commented Mar 19, 2025 •

edited by github-actions bot

Loading

Uh oh!

sobolevn left a comment

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 22, 2025

Uh oh!

bedevere-app bot commented Mar 22, 2025

Uh oh!

bedevere-app bot commented Mar 22, 2025

Uh oh!

bedevere-bot commented Mar 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

gh-131457: Fix typo in BNF description of function signatures #131460

gh-131457: Fix typo in BNF description of function signatures #131460

Uh oh!

Conversation

srinivasreddy commented Mar 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sobolevn left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 22, 2025

Uh oh!

bedevere-app bot commented Mar 22, 2025

Uh oh!

bedevere-app bot commented Mar 22, 2025

Uh oh!

bedevere-bot commented Mar 22, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

srinivasreddy commented Mar 19, 2025 •

edited by github-actions bot

Loading