- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 33.3k
gh-131492: gh-131461: handle exceptions in GzipFile constructor while owning resources #131462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            vstinner
  merged 20 commits into
  python:main
from
graingert:fix-resource-warning-in-gzipfile-ctor
  
      
      
   
  Mar 20, 2025 
      
    
  
     Merged
                    Changes from 10 commits
      Commits
    
    
            Show all changes
          
          
            20 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      8abf17d
              
                gh-131461: fix ResourceWarning when writing a unwritable gzipfile
              
              
                graingert 1193e6c
              
                Merge branch 'main' into fix-resource-warning-in-gzipfile-ctor
              
              
                graingert 04f17ee
              
                remove redundant self.fileobj = None
              
              
                graingert 99d4a47
              
                Update Lib/gzip.py
              
              
                graingert 59ed512
              
                Update Lib/gzip.py
              
              
                graingert 2ac99bd
              
                📜🤖 Added by blurb_it.
              
              
                blurb-it[bot] 0a9c81b
              
                remember to raise
              
              
                graingert cef776c
              
                Update Misc/NEWS.d/next/Library/2025-03-19-14-36-54.gh-issue-131461.u…
              
              
                graingert 49f5a19
              
                Update Lib/gzip.py
              
              
                graingert d627689
              
                Update Lib/gzip.py
              
              
                graingert c9cdbf1
              
                assert no resource warning on tarfile failing to write on open
              
              
                graingert 2217713
              
                refactor gzip closing
              
              
                graingert 97ca4d3
              
                Update Lib/gzip.py
              
              
                graingert c9661e1
              
                Update Lib/gzip.py
              
              
                graingert 8e54c5b
              
                Update Lib/test/test_tarfile.py
              
              
                graingert 15a3058
              
                fix resource warning in GzipFile if anything in the ctor fails such a…
              
              
                graingert 8351549
              
                📜🤖 Added by blurb_it.
              
              
                blurb-it[bot] 7de109e
              
                Merge branch 'main' into fix-resource-warning-in-gzipfile-ctor
              
              
                graingert 052937f
              
                Update Misc/NEWS.d/next/Library/2025-03-20-08-32-49.gh-issue-131492.s…
              
              
                graingert 643a00d
              
                Update Misc/NEWS.d/next/Library/2025-03-20-08-32-49.gh-issue-131492.s…
              
              
                graingert File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
        
          
          
            1 change: 1 addition & 0 deletions
          
          1 
        
  Misc/NEWS.d/next/Library/2025-03-19-14-36-54.gh-issue-131461.uDUmdY.rst
  
  
      
      
   
        
      
      
    
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fix :exc:`ResourceWarning` when constructing a :class:`gzip.GzipFile` in write mode with a broken file object. | 
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.