Skip to content

Conversation

@chris-eibl
Copy link
Member

@chris-eibl chris-eibl commented Mar 19, 2025

Use perf_counter in Stopwatch.

I temporarily added

    def test_denial_of_service_prevented_str_to_int_many(self):
        for i in range(1000):
            self.test_denial_of_service_prevented_str_to_int()

to test_int.py. With process_time it always failed, with perf_counter it always succeeded.

I think this is a skip news?

Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

A

@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 24, 2025
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @encukou for commit 39eb532 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131469%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 24, 2025
@ZeroIntensity ZeroIntensity added the tests Tests in the Lib/test dir label Mar 27, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
@AA-Turner AA-Turner requested a review from encukou April 24, 2025 14:53
@encukou encukou merged commit 11f457c into python:main Apr 28, 2025
38 checks passed
@chris-eibl chris-eibl deleted the stopwatch branch April 28, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants