Skip to content

GH-131296: fix clang-cl warning on Windows in sre.c #131593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

GH-131296: fix clang-cl warning on Windows in sre.c #131593

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
547b5c4
fix clangcl warning in sre.c
chris-eibl Mar 22, 2025
853c1ff
just use "#if defined(_MSC_VER) && !defined(__clang__)"
chris-eibl Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions Modules/_sre/sre.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,8 @@ static unsigned int sre_toupper(unsigned int ch) {

/* -------------------------------------------------------------------- */

#if defined(_MSC_VER)
# if defined(__clang__)
# pragma optimize("", on)
# else
# pragma optimize("gt", on) /* doesn't seem to make much difference... */
# endif
#if defined(_MSC_VER) && !defined(__clang__)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler - just ignore __clang__ and keep agtw for MSVC.

#pragma optimize("agtw", on) /* doesn't seem to make much difference... */
#pragma warning(disable: 4710) /* who cares if functions are not inlined ;-) */
/* fastest possible local call under MSVC */
#define LOCAL(type) static __inline type __fastcall
Expand Down
Loading