Skip to content

gh-131807: fix ResourceWarning in test_ucn.py #131808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2025
Merged

gh-131807: fix ResourceWarning in test_ucn.py #131808

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a10ddb5
fix ResourceWarning in test_ucn.py
graingert Mar 27, 2025
79dabbb
Update Lib/test/test_ucn.py
graingert Mar 28, 2025
c02d8ef
Merge branch 'main' into fix-test-ucn-rw
graingert Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 18 additions & 14 deletions Lib/test/test_ucn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import ast
import unittest
import unicodedata
import urllib.error

from test import support
from http.client import HTTPException
Expand Down Expand Up @@ -181,20 +182,23 @@ def check_version(testfile):
try:
testdata = support.open_urlresource(url, encoding="utf-8",
check=check_version)
except (OSError, HTTPException):
self.skipTest("Could not retrieve " + url)
self.addCleanup(testdata.close)
for line in testdata:
line = line.strip()
if not line or line.startswith('#'):
continue
seqname, codepoints = line.split(';')
codepoints = ''.join(chr(int(cp, 16)) for cp in codepoints.split())
self.assertEqual(unicodedata.lookup(seqname), codepoints)
with self.assertRaises(SyntaxError):
self.checkletter(seqname, None)
with self.assertRaises(KeyError):
unicodedata.ucd_3_2_0.lookup(seqname)
except urllib.error.HTTPError as e:
e.close()
self.skipTest(f"Could not retrieve {url} {e=}")
except (OSError, HTTPException) as e:
self.skipTest(f"Could not retrieve {url} {e=}")
with testdata:
for line in testdata:
line = line.strip()
if not line or line.startswith('#'):
continue
seqname, codepoints = line.split(';')
codepoints = ''.join(chr(int(cp, 16)) for cp in codepoints.split())
self.assertEqual(unicodedata.lookup(seqname), codepoints)
with self.assertRaises(SyntaxError):
self.checkletter(seqname, None)
with self.assertRaises(KeyError):
unicodedata.ucd_3_2_0.lookup(seqname)

def test_errors(self):
self.assertRaises(TypeError, unicodedata.name)
Expand Down
Loading