Skip to content

gh-131015: Add test for bytes formatting errors #131881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 5, 2025
Merged

gh-131015: Add test for bytes formatting errors #131881

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5a547d2
test: bytes formatting errors
ApostolFet Mar 29, 2025
8871037
test: line length correction
ApostolFet Apr 4, 2025
8e57f60
Update Lib/test/test_bytes.py
ApostolFet Apr 4, 2025
ad6cc23
Update Lib/test/test_bytes.py
ApostolFet Apr 4, 2025
6028825
test: use bytes format
ApostolFet Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions Lib/test/test_bytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -772,8 +772,25 @@ def check(fmt, vals, result):
check(b'%i%b %*.*b', (10, b'3', 5, 3, b'abc',), b'103 abc')
check(b'%c', b'a', b'a')

class PseudoFloat:
def __init__(self, value):
self.value = float(value)
def __int__(self):
return int(self.value)

pi = PseudoFloat(3.1415)

self.assertRaisesRegex(TypeError, '%x format: an integer is required, not float', operator.mod, '%x', 3.14)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it so that all lines are under 80 chars please? I think the existing code is breaking that limit but I'm not entirely sure. More generally, you could do mod = operator.mod to reduce the overall line length as well.

mod = operator.mod
msg = "...."
self.assertRaisesRegex(TypeError, msg, mod, ...)

Or use a private helper for this test.

Copy link
Contributor Author

@ApostolFet ApostolFet Apr 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about that option?

        exceptions_params = (
            ('%x format: an integer is required, not float','%x', 3.14),
            ...
        )

        for msg, format, value in exceptions_params:
            self.assertRaisesRegex(TypeError, msg , mod, format, value)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, something like this is fine. It'll become easier to add more test cases later.

self.assertRaisesRegex(TypeError, '%X format: an integer is required, not float', operator.mod, '%X', 2.11)
self.assertRaisesRegex(TypeError, '%o format: an integer is required, not float', operator.mod, '%o', 1.79)
self.assertRaisesRegex(TypeError, '%x format: an integer is required, not PseudoFloat', operator.mod, '%x', pi)
self.assertRaisesRegex(TypeError, '%x format: an integer is required, not complex', operator.mod, '%x', 3j)
self.assertRaisesRegex(TypeError, '%X format: an integer is required, not complex', operator.mod, '%X', 2j)
self.assertRaisesRegex(TypeError, '%o format: an integer is required, not complex', operator.mod, '%o', 1j)
self.assertRaisesRegex(TypeError, '%u format: a real number is required, not complex', operator.mod, '%u', 3j)
self.assertRaisesRegex(TypeError, '%i format: a real number is required, not complex', operator.mod, '%i', 2j)
self.assertRaisesRegex(TypeError, '%d format: a real number is required, not complex', operator.mod, '%d', 2j)
self.assertRaisesRegex(TypeError, r'%c requires an int or a unicode character, not .*\.PseudoFloat', operator.mod, '%c', pi)

def test_imod(self):
b = self.type2test(b'hello, %b!')
Expand Down
Loading