-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-129069: make list ass_slice and memory_repeat safe in free-threading #131882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tom-pytel
wants to merge
68
commits into
python:main
Choose a base branch
from
tom-pytel:fix-issue-129069
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 15 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
0c8dcfc
gh-129069: make list ass_slice and memory_repeat safe
tom-pytel 67c9459
📜🤖 Added by blurb_it.
blurb-it[bot] e460b5a
include atomic wrappers in pycore_list.h
tom-pytel fcdb634
provisional fix to compile on windows
tom-pytel b1e9216
requested changes so far
tom-pytel 944abf0
Merge branch 'main' into fix-issue-129069
tom-pytel 3a9e249
Merge branch 'main' into fix-issue-129069
tom-pytel 0f96d58
remove atomic load and rename
tom-pytel 47f3d81
Merge branch 'main' into fix-issue-129069
tom-pytel adf2c15
Merge branch 'main' into fix-issue-129069
tom-pytel b569865
Merge branch 'main' into fix-issue-129069
tom-pytel 87d48ff
Merge branch 'main' into fix-issue-129069
tom-pytel 26ee081
requested variable name changes
tom-pytel ac4e968
use _Py_IS_ALIGNED()
tom-pytel 890186e
Merge branch 'main' into fix-issue-129069
tom-pytel 7c250fa
Py_ssize_t arg -> size_t
tom-pytel a0dca26
Merge branch 'main' into fix-issue-129069
tom-pytel 80c12d2
add tests and remove suppressions
tom-pytel f16eb60
Merge branch 'main' into fix-issue-129069
tom-pytel e36e314
Merge branch 'main' into fix-issue-129069
tom-pytel f220d83
add list free-threading tsan test to test_list.py
tom-pytel bed61d9
misc fix test_list.test_free_threading, no tsan req
tom-pytel 656a5a0
fix list tsan test
tom-pytel d34d11a
change news
tom-pytel 8610e27
Merge branch 'main' into fix-issue-129069
tom-pytel ce439d7
test build fix
tom-pytel a16cf5b
control test with original main pyatomic.h
tom-pytel 8ab9d16
fix typo
tom-pytel 8e2d83e
remove capi tests
tom-pytel 1c14be7
restore atomic mem funcs
tom-pytel 9bf93f2
another test
tom-pytel 272fec6
another test
tom-pytel 0721321
final test hopefully to diagnose
tom-pytel e34fa03
hunch
tom-pytel a7850be
fingers crossed
tom-pytel be4f118
misc
tom-pytel 23c1bce
test as #define
tom-pytel aef4baa
reorder to end of pyatomic.h
tom-pytel b26b262
revert _Py_IS_ALIGNED() to raw checks
tom-pytel 839f772
revert size_t to Py_ssize_t
tom-pytel c8fb961
explicitly include string.h for test
tom-pytel 32238cb
double check _Py_IS_ALIGNED()
tom-pytel 08298ee
again
tom-pytel 5d372b7
and again
tom-pytel a6eb550
uintptr_t?
tom-pytel e2c5f2e
completely empty functions
tom-pytel c3a23fb
loop and normal store
tom-pytel 5813655
put back assert
tom-pytel 635d217
_Py_USING_STD and normal store
tom-pytel 088c40e
pyatomic_gcc store atomic
tom-pytel 2063f73
pyatomic_std store atomic
tom-pytel 11b616c
pyatomic_msc store atomic
tom-pytel 191c261
put back assert n
tom-pytel 0784d19
typecase to size_t in assert
tom-pytel 154a132
size assert no work, try other with cast
tom-pytel a5f4d9e
last test of copy at pyatomic.h level
tom-pytel 73c7cc1
test location dependence
tom-pytel 93b90c7
put back test
tom-pytel bf15e93
test basic assert
tom-pytel 39bee16
leave assertions commented out
tom-pytel 387232d
Merge branch 'main' into fix-issue-129069
tom-pytel 6f4ef28
test assert(1 == 1) with latest main
tom-pytel c2de542
remove assert(1 == 1) test, now we know
tom-pytel e6d3e5c
#include <assert.h>
tom-pytel 9c4debd
Merge branch 'main' into fix-issue-129069
kumaraditya303 f167747
Merge branch 'main' into fix-issue-129069
tom-pytel 32f9604
make C90 compatible
tom-pytel 00c57d3
Merge branch 'main' into fix-issue-129069
tom-pytel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Core_and_Builtins/2025-03-29-20-12-28.gh-issue-129069.QwbbWV.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Fix data race and avoid jagged writes in ``list.list_ass_slice``. | ||
kumaraditya303 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.