Skip to content

gh-83371: route multiprocessing Pool callback failures to AsyncResult #131883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

gh-83371: route multiprocessing Pool callback failures to AsyncResult #131883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 24 additions & 9 deletions Lib/multiprocessing/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -774,11 +774,18 @@ def get(self, timeout=None):
raise self._value

def _set(self, i, obj):
self._success, self._value = obj
if self._callback and self._success:
self._callback(self._value)
if self._error_callback and not self._success:
self._error_callback(self._value)
success, value = obj
try:
if self._callback and success:
self._callback(value)
if self._error_callback and not success:
self._error_callback(value)
except BaseException as e:
self._value = e
self._success = False
else:
self._value = value
self._success = success
self._event.set()
del self._cache[self._job]
self._pool = None
Expand Down Expand Up @@ -812,8 +819,12 @@ def _set(self, i, success_result):
if success and self._success:
self._value[i*self._chunksize:(i+1)*self._chunksize] = result
if self._number_left == 0:
if self._callback:
self._callback(self._value)
try:
if self._callback:
self._callback(self._value)
except BaseException as e:
self._value = e
self._success = False
del self._cache[self._job]
self._event.set()
self._pool = None
Expand All @@ -824,8 +835,12 @@ def _set(self, i, success_result):
self._value = result
if self._number_left == 0:
# only consider the result ready once all jobs are done
if self._error_callback:
self._error_callback(self._value)
try:
if self._error_callback:
self._error_callback(self._value)
except BaseException as e:
self._value = e
self._success = False
del self._cache[self._job]
self._event.set()
self._pool = None
Expand Down
Loading