gh-84481: Add ZipFile.data_offset attribute #132165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This attribute provides the offset to zip data from the start of the file, when available.
|
All commit authors signed the Contributor License Agreement. |
|
I have signed the CLA with my current email. (I had already signed it under another email anyway) |
gpshead
approved these changes
Apr 6, 2025
picnixz
reviewed
Apr 6, 2025
| self.fp = _Tellable(self.fp) | ||
| self.start_dir = 0 | ||
| self._seekable = False | ||
| self._data_offset = None |
There was a problem hiding this comment.
It may not be set if mode == 'a' and if BadZipFile is raised. In this case, we should still have a None according to the docs (otherwise an AttributeError will be raised).
For mode 'r', it should be noted that failing _RealGetContents() means that the object will never be initialized so we don't care about the lack of attribute.
There was a problem hiding this comment.
I believe that in this case, since mode 'a' calls tell() unconditionally, we can set the data_offset to the result of that, right?
There was a problem hiding this comment.
Though honestly the defensive thing to do here is to initialize it to None early on then change it later when possible.
There was a problem hiding this comment.
Though honestly the defensive thing to do here is to initialize it to None early on then change it later when possible.
Yes, that's what I thought.
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
* Add ZipFile.data_offset attribute This attribute provides the offset to zip data from the start of the file, when available. * Add blurb-it * Try fixing class ref in NEWS
emmatyping
added a commit
to emmatyping/cpython
that referenced
this pull request
Jul 21, 2025
)" This reverts commit 0788948.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 21, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
gpshead
added a commit
that referenced
this pull request
Jul 22, 2025
…36955) gh-136170: Revert adding `ZipFile.data_offset` (GH-136950) * Revert "gh-84481: Make ZipFile.data_offset more robust (GH-132178)" This reverts commit 6cd1d6c. * Revert "gh-84481: Add ZipFile.data_offset attribute (GH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165)" This reverts commit 0788948. --------- Co-authored-by: Gregory P. Smith <[email protected]>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
* Revert "pythongh-84481: Make ZipFile.data_offset more robust (python#132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (python#132165)" This reverts commit 0788948. --------- Co-authored-by: Gregory P. Smith <[email protected]>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…-136950) (python#136955) pythongh-136170: Revert adding `ZipFile.data_offset` (pythonGH-136950) * Revert "pythongh-84481: Make ZipFile.data_offset more robust (pythonGH-132178)" This reverts commit 6cd1d6c. * Revert "pythongh-84481: Add ZipFile.data_offset attribute (pythonGH-132165)" This reverts commit 0788948. --------- (cherry picked from commit 6bf1c0a) Co-authored-by: Emma Smith <[email protected]> Co-authored-by: Gregory P. Smith <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute provides the offset to zip data from the start of the file, when available.
I chose
data_offsetto avoid confusion with the_offsetproperty that is unrelated.📚 Documentation preview 📚: https://cpython-previews--132165.org.readthedocs.build/