Skip to content

gh-132176: Fix crash on type() when tuple subclass passed as bases #132212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 15, 2025
Merged

gh-132176: Fix crash on type() when tuple subclass passed as bases #132212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
40bf263
gh-132176: Fix crash on `type()` when `tuple` subclass passed as `bases`
sobolevn Apr 7, 2025
603eb00
Delete Misc/NEWS.d/next/Core_and_Builtins/2025-04-07-12-50-10.gh-issu…
sobolevn Apr 14, 2025
b04c998
Update Lib/test/test_types.py
sobolevn Apr 15, 2025
b4b7f12
Update Lib/test/test_types.py
sobolevn Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Lib/test/test_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1819,6 +1819,15 @@ class Model(metaclass=ModelBase):
with self.assertRaises(RuntimeWarning):
type("SouthPonies", (Model,), {})

def test_tuple_subclass_as_bases(self):
# gh-132176: it used to crash on using
# tuple subclass for as base classes.
class TupleSubclass(tuple): pass

typ = type("typ", TupleSubclass((int, object)), {})
self.assertEqual(typ.__bases__, (int, object))
self.assertEqual(type(typ.__bases__), TupleSubclass)


class SimpleNamespaceTests(unittest.TestCase):

Expand Down
3 changes: 2 additions & 1 deletion Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,10 +497,11 @@ _PyType_GetBases(PyTypeObject *self)
static inline void
set_tp_bases(PyTypeObject *self, PyObject *bases, int initial)
{
assert(PyTuple_CheckExact(bases));
assert(PyTuple_Check(bases));
if (self->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN) {
// XXX tp_bases can probably be statically allocated for each
// static builtin type.
assert(PyTuple_CheckExact(bases));
assert(initial);
assert(self->tp_bases == NULL);
if (PyTuple_GET_SIZE(bases) == 0) {
Expand Down
Loading