gh-132185: Speed up expanduser() test with large password database #132231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use only random selected entries if the "cpu" resource is not enabled.
serhiy-storchaka
added
tests
|
@itamaro, how much it takes to test 1000 entries? 10000 entries? |
let me test with these limits |
about a minute for 10k, under 5sec for 1k |
|
Thank you. This is much slower than on normal Linux PC, so I would be wrong without your data. |
itamaro
reviewed
Apr 7, 2025
itamaro
approved these changes
Apr 7, 2025
picnixz
reviewed
Apr 7, 2025
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
approved these changes
Apr 7, 2025
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 12, 2025
…ase (pythonGH-132231) Use only a limited number of randomly selected entries. (cherry picked from commit 842ab81) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-132443 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Apr 12, 2025
…base (GH-132231) (GH-132443) Use only a limited number of randomly selected entries. (cherry picked from commit 842ab81) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use only random selected entries if the "cpu" resource is not enabled.