-
-
Notifications
You must be signed in to change notification settings - Fork 33.2k
gh-132250: Clear error in lsprof callback when method descriptor raises an excep… #132251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
8f706d1
Clear error in lsprof callback when method descriptor raises an excep…
gaogaotiantian 36d5bff
Update comments
gaogaotiantian d23b23f
📜🤖 Added by blurb_it.
blurb-it[bot] 07c0a06
Update Misc/NEWS.d/next/Library/2025-04-08-01-55-11.gh-issue-132250.A…
gaogaotiantian a22b4a4
Use comments instead of docstring
gaogaotiantian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2025-04-08-01-55-11.gh-issue-132250.APBFCw.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Fixed the :exc:`SystemError` in :mod:`cProfile` when locating the actual c function of a method raises an exception. | ||
gaogaotiantian marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is used above, but I am not a fan of docstrings in unittests :( Docstrings can be shown during test execution.
Let's maybe convert it to comments?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have problem converting it to comments, but it seems to be pretty random if we do it case by case. I think we have plenty of docstrings in our test suite. I always use
python -m testfor stdlib tests so the docstring never bothers me. Do you useunittestdirectly for these tests? If we want to even soft-enforce this, we should probably discuss it among some core devs and put it somewhere in the devguide. Most people won't be able to see it, but we can refer to it during code reviews and we can gradually make it happen.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I converted this to a comment - I don't have a strong opinion on this (it's easier to do a docstring if the description is long so I normally just do a docstring). If you believe this actually matters in some cases, we should probably discuss it and put it to somewhere in devguide. It would be helpful for people like us to make a decision and get use to it :)