Skip to content

doc: update co_flags reference #132300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

doc: update co_flags reference #132300

merged 4 commits into from
Apr 24, 2025

Conversation

@methane
Copy link
Member

@methane methane commented Apr 9, 2025 •
edited by github-actions bot
Loading

@methane methane added type-bug An unexpected behavior, bug, or error docs Documentation in the Doc dir skip issue skip news needs backport to 3.13 bugs and security fixes labels Apr 9, 2025
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Apr 9, 2025
@methane methane changed the title doc: true division doesn't use co_flags anymore doc: update co_flags reference Apr 10, 2025
@methane methane requested a review from iritkatriel April 10, 2025 05:41
@methane methane requested a review from markshannon April 10, 2025 05:42
iritkatriel
iritkatriel reviewed Apr 10, 2025
View reviewed changes
hugovk
hugovk reviewed Apr 24, 2025
View reviewed changes
@hugovk hugovk enabled auto-merge (squash) April 24, 2025 14:01
@hugovk hugovk merged commit b1f2304 into python:main Apr 24, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 24, 2025
@miss-islington-app
Copy link

Thanks @methane for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @methane and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker b1f2304b206c4db0ad6531f254d5bd60a2d605d9 3.13

@hugovk
Copy link
Member

hugovk commented Apr 24, 2025

@methane Does this need backporting?

@methane
Copy link
Member Author

methane commented Apr 25, 2025

@hugovk CO_HAS_DOCSTRING is new in Python 3.14.

Other flags are changed in Python 3.9 commit.
So first paragraph change should be backported.

@methane methane deleted the truediv-bits branch April 25, 2025 02:26
@bedevere-app
Copy link

bedevere-app bot commented Apr 25, 2025

GH-132936 is a backport of this pull request to the 3.13 branch.

hugovk added a commit to hugovk/cpython that referenced this pull request Apr 25, 2025
@methane @hugovk
[3.13] doc: update co_flags reference (pythonGH-132300)
88f09fb 
(cherry picked from commit b1f2304)

Co-authored-by: Inada Naoki <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
hugovk added a commit that referenced this pull request Apr 26, 2025
@hugovk @methane
[3.13] doc: update co_flags reference (GH-132300) (#132936)
2c9842f 
Co-authored-by: Inada Naoki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@iritkatriel iritkatriel iritkatriel approved these changes

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@markshannon markshannon Awaiting requested review from markshannon

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir skip issue skip news type-bug An unexpected behavior, bug, or error

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@methane @hugovk @iritkatriel