Skip to content

gh-132307: Remove unnecessary check in asyncio/base_events.py #132324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 10, 2025
Merged

gh-132307: Remove unnecessary check in asyncio/base_events.py #132324

merged 2 commits into from
Apr 10, 2025

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Apr 9, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 9, 2025
Closed
ZeroIntensity
ZeroIntensity reviewed Apr 10, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For anyone interested in a follow-up, we should add a test for using an SSL socket here when ssl isn't available; nothing failed with the first iteration.

@kumaraditya303 kumaraditya303 enabled auto-merge (squash) April 10, 2025 15:26
@kumaraditya303 kumaraditya303 merged commit a214db0 into python:main Apr 10, 2025
42 checks passed
@StanFromIreland StanFromIreland deleted the gh-132307 branch April 10, 2025 15:45
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@StanFromIreland @seehwan80
pythongh-132307: Remove unnecessary check in asyncio/base_events.py (…
57626bc 
…python#132324)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

Assignees

No one assigned

Labels

skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@StanFromIreland @ZeroIntensity @kumaraditya303