Skip to content

gh-132470: Prevent crash in ctypes.CField when byte_size is incorrect #132475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2025
Merged

gh-132470: Prevent crash in ctypes.CField when byte_size is incorrect #132475

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
45aa6a3
Fix: Prevent crash in ctypes.CField when byte_size does not match typ…
dura0ok Apr 13, 2025
3377d9a
Add regression test for invalid byte_size in ctypes.CField
dura0ok Apr 13, 2025
4c558be
add news
dura0ok Apr 13, 2025
b20b0d8
fix review test
dura0ok Apr 13, 2025
be00372
Update news
dura0ok Apr 16, 2025
1d5f7cb
fix space
dura0ok Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Modules/_ctypes/cfield.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,12 @@ PyCField_new_impl(PyTypeObject *type, PyObject *name, PyObject *proto,
"type of field %R must be a C type", name);
goto error;
}
assert(byte_size == info->size);
if (byte_size != info->size) {
PyErr_Format(PyExc_ValueError,
"byte size of field %R (%zd) does not match type size (%zd)",
name, byte_size, info->size);
goto error;
}

Py_ssize_t bitfield_size = 0;
Py_ssize_t bit_offset = 0;
Expand Down
Loading