Skip to content

annotationlib: Remove some unnecessary dict copies #132495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 16, 2025
Merged

annotationlib: Remove some unnecessary dict copies #132495

merged 2 commits into from
Apr 16, 2025

Conversation

@JelleZijlstra
Copy link
Member

We were copying the dictionary multiple times in a few cases. Once is enough.

AlexWaygood
AlexWaygood reviewed Apr 15, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add some comments or docstrings to indicate clearly which internal functions are meant to uphold the invariant that they always return a fresh dictionary, and which aren't?

@JelleZijlstra
Copy link
Member Author

Good point, added docstrings

AlexWaygood
AlexWaygood approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@JelleZijlstra JelleZijlstra merged commit a8ca26d into python:main Apr 16, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JelleZijlstra @AlexWaygood