gh-132099: Accept an integer as the address for BTPROTO_HCI on Linux #132525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Linux Previously only an integer packed in a tuple was accepted, while getsockname() could return a raw integer. Now the result of getsockname() is always acceptable as an address.
| - On Linux it accepts an integer ``device_id`` or a tuple | ||
| ``(device_id, [channel])`` where ``device_id`` | ||
| is specifies the number of the Bluetooth device, | ||
| and ``channel`` is an optional integer specifying the HCI channel |
There was a problem hiding this comment.
Suggested change
| and ``channel`` is an optional integer specifying the HCI channel | |
| and ``channel`` is an optional integer specifying the HCI channel. |
There was a problem hiding this comment.
No, it is not the end of the sentence.
Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only an integer packed in a tuple was accepted, while getsockname() could return a raw integer.
Now the result of getsockname() is always acceptable as an address.
📚 Documentation preview 📚: https://cpython-previews--132525.org.readthedocs.build/