typing docs: Clarify Protocol / runtime_checkable docs #132606
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicitly say that isinstance/issubclass do not work on non-runtime checkable protocols. - Move the sentence "This raises TypeError when applied to a non-protocol class". It took me quite some time to decide what "this" was here: it refers to applying the decorator, not to an isinstance() call.
JelleZijlstra
added
skip issue
skip news
needs backport to 3.13
AlexWaygood
approved these changes
Apr 16, 2025
Co-authored-by: Alex Waygood <[email protected]>
|
Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 16, 2025
- Explicitly say that isinstance/issubclass do not work on non-runtime checkable protocols. - Move the sentence "This raises TypeError when applied to a non-protocol class". It took me quite some time to decide what "this" was here: it refers to applying the decorator, not to an isinstance() call. (cherry picked from commit 14efcad) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
|
GH-132607 is a backport of this pull request to the 3.13 branch. |
AlexWaygood
added a commit
that referenced
this pull request
Apr 16, 2025
) (#132607) Co-authored-by: Jelle Zijlstra <[email protected]> Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protocols.
took me quite some time to decide what "this" was here: it refers to applying the
decorator, not to an isinstance() call.
📚 Documentation preview 📚: https://cpython-previews--132606.org.readthedocs.build/