gh-123503: Replace usages of addinfourl and HTTPResponse deprecated attributes with stable ones
#132644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Apr 17, 2025
There was a problem hiding this comment.
We need a NEWS entry, small one. Because now, we're making assumptions that the response object has a .status field, which is only true since Python 3.9. Thankfully, 3.9 is the last security branch, so script running with 3.9 may still somehow run without issues on 3.14 (thus we would mitigate the porting issues).
Lib/urllib/request.py
Outdated
|
|
||
| def http_response(self, request, response): | ||
| code, msg, hdrs = response.code, response.msg, response.info() | ||
| code, msg, hdrs = response.status, response.msg, response.info() |
There was a problem hiding this comment.
Why not changing response.info() as well?
picnixz
changed the title
urllib/requestaddinfourl and HTTPResponse deprecated attributes with stable ones
picnixz
changed the title
addinfourl and HTTPResponse deprecated attributes with stable onesaddinfourl and HTTPResponse deprecated attributes with stable ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I replaced deprecated features with the recommended current features(updated to the latest version)
HTTPErrorProcessoruses deprecated members ofaddinfourl/HTTPResponse#123503