Skip to content

gh-130167: Improve the error case for textwrap.dedent #132666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 19, 2025
Merged

gh-130167: Improve the error case for textwrap.dedent #132666

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c820cd
Improve the error case for ``textwrap.dedent``
AA-Turner Apr 18, 2025
d236d0c
Add a test
AA-Turner Apr 18, 2025
ec839ff
Improve the error message for bytes
AA-Turner Apr 18, 2025
1902d1c
Suppress BytesWarning
AA-Turner Apr 18, 2025
a996f00
Remove fast path
AA-Turner Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Lib/textwrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,11 @@ def dedent(text):
if not text:
return text

lines = text.split('\n')
try:
lines = text.split('\n')
except AttributeError:
msg = f'expected str object, not {type(text).__qualname__!r}'
raise TypeError(msg) from None

# Get length of leading whitespace, inspired by ``os.path.commonprefix()``.
non_blank_lines = [l for l in lines if l and not l.isspace()]
Expand Down
2 changes: 1 addition & 1 deletion Misc/NEWS.d/3.14.0a7.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ Improve the import time of the :mod:`ast` module by extracting the
.. nonce: 8M-HVz
.. section: Library

Improved performance of :func:`textwrap.dedent` by an average of ~1.3x.
Improved performance of :func:`textwrap.indent` by an average of ~1.3x.
Patch by Adam Turner.

..
Expand Down
Loading