Skip to content

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Apr 19, 2025

Depending on the configuration, the last field is not _initial_thread. I also fixed a typo I left in the previous commit.

@picnixz picnixz changed the title gh-127117: ensure that _initial_thread is the last field of PyInterpreterState gh-127117: ensure that _initial_thread is the last field of PyInterpreterState when Py_STACKREF_DEBUG is defined Apr 19, 2025
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For anyone looking for a fun project: it would be nice if we had a way to test for this.

@picnixz picnixz self-assigned this Apr 19, 2025
@kumaraditya303 kumaraditya303 merged commit 246ed23 into python:main Apr 20, 2025
49 checks passed
@picnixz picnixz deleted the fix/interp/interpreter-state-layout-127117 branch April 20, 2025 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants