Skip to content

Update pre-commit repos #132792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2025
Merged

Update pre-commit repos #132792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7803661
Update zizmor to `v1.6.0`
sobolevn Apr 22, 2025
12f77ca
Update other `pre-commit` repos
sobolevn Apr 22, 2025
420edd8
Apply changes
sobolevn Apr 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/zizmor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,7 @@ rules:
dangerous-triggers:
ignore:
- documentation-links.yml
unpinned-uses:
config:
policies:
"*": ref-pin
8 changes: 4 additions & 4 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.11.4
rev: v0.11.6
hooks:
- id: ruff
name: Run Ruff (lint) on Doc/
Expand All @@ -24,7 +24,7 @@ repos:
files: ^Doc/

- repo: https://github.com/psf/black-pre-commit-mirror
rev: 24.10.0
rev: 25.1.0
hooks:
- id: black
name: Run Black on Tools/build/check_warnings.py
Expand All @@ -49,7 +49,7 @@ repos:
types_or: [c, inc, python, rst]

- repo: https://github.com/python-jsonschema/check-jsonschema
rev: 0.31.0
rev: 0.33.0
hooks:
- id: check-dependabot
- id: check-github-workflows
Expand All @@ -61,7 +61,7 @@ repos:
- id: actionlint

- repo: https://github.com/woodruffw/zizmor-pre-commit
rev: v1.1.1
rev: v1.6.0
hooks:
- id: zizmor

Expand Down
8 changes: 5 additions & 3 deletions Tools/jit/_stencils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,17 +238,19 @@ def remove_jump(self) -> None:
addend=-4,
) as hole:
# jmp qword ptr [rip]
jump = b"\x48\xFF\x25\x00\x00\x00\x00"
jump = b"\x48\xff\x25\x00\x00\x00\x00"
offset -= 3
case Hole(
offset=offset,
kind="IMAGE_REL_I386_REL32" | "R_X86_64_PLT32" | "X86_64_RELOC_BRANCH",
value=HoleValue.CONTINUE,
symbol=None,
addend=addend,
) as hole if _signed(addend) == -4:
) as hole if (
_signed(addend) == -4
):
Comment on lines +249 to +251
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intentional change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails with the updated lint: https://github.com/python/cpython/actions/runs/14595721490/job/40941024229

# jmp 5
jump = b"\xE9\x00\x00\x00\x00"
jump = b"\xe9\x00\x00\x00\x00"
offset -= 1
case Hole(
offset=offset,
Expand Down
2 changes: 1 addition & 1 deletion Tools/jit/_targets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class _Target(typing.Generic[_S, _R]):

def _get_nop(self) -> bytes:
if re.fullmatch(r"aarch64-.*", self.triple):
nop = b"\x1f\x20\x03\xD5"
nop = b"\x1f\x20\x03\xd5"
elif re.fullmatch(r"x86_64-.*|i686.*", self.triple):
nop = b"\x90"
else:
Expand Down
Loading