gh-132796: Closes SMTP connection on 421 during data in sendmail #132797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a minor issue in smtlib.SMTP.sendmail that leads to SMTP client connections not being closed when a server responds with 421 during a DATA command. The existing 421 handling covers almost all cases, but as the DATA command method already handles some error response codes, the 421 is masked for sendmail.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
No worries, thanks for taking the time! I have just added the NEWS entry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a minor issue in smtlib.SMTP.sendmail that leads to SMTP client connections not being closed when a server responds with 421 during a DATA command. The existing 421 handling covers almost all cases, but as the DATA command method already handles some error response codes, the 421 is masked for sendmail.