Skip to content

gh-109981: Resolve situation on iOS regarding fd_count. #132823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2025
Merged

gh-109981: Resolve situation on iOS regarding fd_count. #132823

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9857e3
test: Resolve situation on iOS regarding fd_count.
johnzhou721 Apr 23, 2025
41ebe71
trigger ci
johnzhou721 Apr 23, 2025
2ba9225
📜🤖 Added by blurb_it.
blurb-it[bot] Apr 23, 2025
909c332
Small tweak to release note.
freakboy3742 Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/support/os_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@ def fd_count():
"""
if sys.platform.startswith(('linux', 'android', 'freebsd', 'emscripten')):
fd_path = "/proc/self/fd"
elif sys.platform == "darwin":
elif support.is_apple:
fd_path = "/dev/fd"
else:
fd_path = None
Expand Down
5 changes: 5 additions & 0 deletions Misc/NEWS.d/next/Tests/2025-04-23-02-23-37.gh-issue-109981.IX3k8p.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Use ``/dev/fd`` on other Apple platforms, in addition to macOS, to determine
the number of open files in ``test.support.os_helper.fd_count`` to avoid a crash
with "guarded" file descriptors when probing for open files.

The text for this entry is adapted from the previous one fixing the issue for macOS.
Loading