Skip to content

gh-132825: Enhance unhashable error messages for dict and set #132828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2025
Merged

gh-132825: Enhance unhashable error messages for dict and set #132828

merged 2 commits into from
Apr 23, 2025

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Apr 23, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 23, 2025
Closed
@vstinner vstinner changed the title gh-132825: Change unhashable key error messages for dict and set gh-132825: Enhance unhashable error messages for dict and set Apr 23, 2025
cfbolz
cfbolz approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@cfbolz cfbolz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is great thanks for working on this right away, Victor! As @methane pointed out, maybe Cannot -> cannot. We don't have a style guide or anything for exception messages, so maybe it doesn't matter either.

@vstinner
Copy link
Member Author

maybe Cannot -> cannot

Done: I replaced "Cannot ..." with "cannot ...".

@rhettinger rhettinger removed their request for review April 23, 2025 14:46
@cfbolz cfbolz merged commit 426449d into python:main Apr 23, 2025
42 checks passed
@vstinner vstinner deleted the unhashable branch April 23, 2025 15:16
@matthiask
Copy link

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

@vstinner
Copy link
Member Author

Thanks for this improvement! One minor nit: I like wordplays but I'm not sure if the T in unhashTable has been introduced on purpose?

It wasn't done on purpose, it's a typo :-( I wrote #132847 to fix the typo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cfbolz cfbolz cfbolz approved these changes

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@methane methane Awaiting requested review from methane methane is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vstinner @matthiask @cfbolz