gh-53185: Use C type names in c-api/args.rst
#132833
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
awaiting review
docs
StanFromIreland
changed the title
c-api/args.rstc-api/args.rst
vstinner
reviewed
Apr 23, 2025
| for a writable buffer, or whether another thread can mutate the data). | ||
|
|
||
| ``s`` (:class:`str`) [const char \*] | ||
| ``"s"`` (:c:type:`PyUnicodeObject\*`) [:c:type:`const char\*`] |
There was a problem hiding this comment.
There are warnings if you look at the Files Changes tab. Examples:
- Unparseable C cross-reference: 'PyUnicodeObject*'
- Unparseable C cross-reference: 'const char*'
There was a problem hiding this comment.
Ah yes, a lot has changed since your patch
|
Hum, for this documentation, I would prefer to keep Python names. IMO it's more common to see Python names than @serhiy-storchaka: Do you have an opinion on this change? |
|
I agree with @vstinner. These are references to types from Python side, they should use Python names. |
|
@vstinner The issue can be closed then if this will not be done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #53185 (comment)
Request @vstinner (I can send the other PR's but I wanted to verify you still want to do this :-)
📚 Documentation preview 📚: https://cpython-previews--132833.org.readthedocs.build/