Skip to content

Conversation

@Yzi-Li
Copy link
Contributor

@Yzi-Li Yzi-Li commented Apr 24, 2025

Fix some typos of document strings in python files.

skirpichev
skirpichev previously approved these changes Apr 24, 2025

def _installation_is_relocated():
"""Is the Python installation running from a different prefix than what was targetted when building?"""
"""Is the Python installation running from a different prefix than what was targeted when building?"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this is a quirk between British and American English. I think this is probably the more common term, but let's be careful to not set precedent for copycat PRs that switch variations of English.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks.

Copy link
Member

@StanFromIreland StanFromIreland Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently there are 6 occurrences of targeted and 2 of targetted. I however am unable to find any British English dictionary that lists targetted. cc @AA-Turner Because I think he likes this kind of thing ;-)

Edit: just refreshed the page, sorry Adam!

@AA-Turner
Copy link
Member

This is churn, there's nothing user-facing here.

A

@AA-Turner AA-Turner closed this Apr 24, 2025
@Yzi-Li
Copy link
Contributor Author

Yzi-Li commented Apr 25, 2025

Ok, I see. I will avoid it in the future.

@Yzi-Li Yzi-Li deleted the fix-pyfile-typos branch April 25, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants