Skip to content

gh-132909: handle overflow for 'K' format in do_mkvalue #132911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

gh-132909: handle overflow for 'K' format in do_mkvalue #132911

merged 3 commits into from
Apr 25, 2025

Conversation

@picnixz
Copy link
Member

@picnixz picnixz commented Apr 25, 2025 •
edited by github-actions bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Closed
serhiy-storchaka
serhiy-storchaka reviewed Apr 25, 2025
View reviewed changes
@picnixz picnixz changed the title gh-132909: handle overflows for 'K' and 'u' formats in do_mkvalue gh-132909: handle overflows for 'K' format in do_mkvalue Apr 25, 2025
@picnixz picnixz changed the title gh-132909: handle overflows for 'K' format in do_mkvalue gh-132909: handle overflow for 'K' format in do_mkvalue Apr 25, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Apr 25, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@picnixz picnixz enabled auto-merge (squash) April 25, 2025 10:37
@picnixz picnixz added the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
@picnixz picnixz merged commit 3fa024d into python:main Apr 25, 2025
48 checks passed
@miss-islington-app
Copy link

Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @picnixz, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3fa024dec32e2ff86baf3dd7e14a0b314855327c 3.13

@picnixz picnixz deleted the fix/capi/mkvalue-overflows-132909 branch April 25, 2025 11:12
@bedevere-app
Copy link

bedevere-app bot commented Apr 25, 2025

GH-132932 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 25, 2025
picnixz added a commit that referenced this pull request Apr 25, 2025
@picnixz
[3.13] gh-132909: handle overflow for 'K' format in do_mkvalue (G…
7ebfc6e 
…H-132911) (#132932)

(cherry picked from commit 3fa024d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees

@picnixz picnixz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@picnixz @serhiy-storchaka