Simplify HTMLParser by removing unnecessary assignment and assertion #132972
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| i = self.updatepos(i, k) | ||
| continue | ||
| match = incomplete.match(rawdata, i) | ||
| if match: |
There was a problem hiding this comment.
Are there tests for this branch?
Can you elaborate on when this branch is executed, and possibly add a test that ensures that the position just needs to be updated to i + 1 and not k?
There was a problem hiding this comment.
I have no idea what the ideal code should be — this is already an edge-case, that in a previous strict mode caused the parsing to fail.
This un-executed code was added in 2010 — maybe @bitdancer has more context (though I can hardly remember what I did last month, let alone answer for code I wrote 15 years ago).
My general rule in these things is to clear up code so it matches what executes in production, and remove things that might trip up someone debugging the code into thinking the code did something.
There was a problem hiding this comment.
No surprise, I have no memory of this. Looking at the original diff I don't see that that if on k was doing anything, and certainly in the current code it isn't doing anything. k doesn't have a meaningful value at that point, and isn't used.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
4 participants
The assignment to
kis never used, because the block breaks.Unused assignment originally introduced in b579dba