gh-87859: Track Code Object Local Kinds For Arguments #132980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsnowcurrently
requested review from
iritkatriel and
markshannon
as code owners
iritkatriel
reviewed
Apr 28, 2025
Python/assemble.c
Outdated
| PyErr_NoMemory(); | ||
| return ERROR; | ||
| } | ||
| int numargvars = 0; |
There was a problem hiding this comment.
Would it be possible to move this new code to after kinds was calculated, and then you don't need to allocate the argkinds array (just modify the kinds array)?
There was a problem hiding this comment.
I think I can make that work without slowing things down.
|
We should add a test for the new flags. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this was always the intention. I was finally motivated to find the time to do it.
See #87859 (comment).