gh-91221: fix test_curses.test_use_default_colors for xterm-256color
#132990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
changed the title
test_curses.test_use_default_colors for xterm256-colortest_curses.test_use_default_colors for xterm-256color
picnixz
commented
Apr 26, 2025
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 26, 2025
…56color (pythonGH-132990) Terminals with `xterm-256color` Xterm support may use 15 (bright white) as their default foreground color. (cherry picked from commit 7f02ded) Co-authored-by: Bénédikt Tran <[email protected]>
|
GH-132992 is a backport of this pull request to the 3.13 branch. |
picnixz
deleted the
test/fix/alternative-curses-test-use-default-colors-91221
branch
picnixz
added a commit
that referenced
this pull request
Apr 26, 2025
…256color (GH-132990) (#132992) gh-91221: fix `test_curses.test_use_default_colors` for xterm-256color (GH-132990) Terminals with `xterm-256color` Xterm support may use 15 (bright white) as their default foreground color. (cherry picked from commit 7f02ded) Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #132986, and possibly preferrable. It should at least prevent users using openSUSE and/or konsole but others with custom terminfo configuration may still have a failing test.