gh-132993: expose HASHLIB_GIL_MINSIZE to private extension modules
#132999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpshead
reviewed
Apr 26, 2025
picnixz
force-pushed
the
feat/hashlib/gil-minsize-132993
branch
from
d13077c to
4936441
Compare
picnixz
force-pushed
the
feat/hashlib/gil-minsize-132993
branch
from
4936441 to
ca0ab3b
Compare
gpshead
approved these changes
Apr 27, 2025
The pure Python implementation actually calls the underlying C functions so in a sense we may still release the GIL.
|
I actually committed after your approval: it's just that I incorrectly skipped a test (the pure Python implementation still somehow releases the GIL as it calls the underlying C hash functions) |
|
Mmh, I have a local issue if I disable |
|
Ok, nvm, it was because I didn't run |
picnixz
changed the title
HASHLIB_GIL_MINSIZE to (private) extension modulesHASHLIB_GIL_MINSIZE to private extension modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HASHLIB_GIL_MINSIZE#132993