Skip to content
Merged
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 7 additions & 13 deletions Lib/test/test_pyrepl/test_pyrepl.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,15 @@ def run_repl(
*,
cmdline_args: list[str] | None = None,
cwd: str | None = None,
skip: bool = True,
) -> tuple[str, int]:
temp_dir = None
if cwd is None:
temp_dir = tempfile.TemporaryDirectory(ignore_cleanup_errors=True)
cwd = temp_dir.name
try:
return self._run_repl(
repl_input, env=env, cmdline_args=cmdline_args, cwd=cwd
repl_input, env=env, cmdline_args=cmdline_args, cwd=cwd, skip=skip,
)
finally:
if temp_dir is not None:
Expand All @@ -64,6 +65,7 @@ def _run_repl(
env: dict | None,
cmdline_args: list[str] | None,
cwd: str,
skip: bool,
) -> tuple[str, int]:
assert pty
master_fd, slave_fd = pty.openpty()
Expand Down Expand Up @@ -121,7 +123,10 @@ def _run_repl(
except subprocess.TimeoutExpired:
process.kill()
exit_code = process.wait()
return "".join(output), exit_code
output = "".join(output)
if skip and "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
return output, exit_code


class TestCursorPosition(TestCase):
Expand Down Expand Up @@ -1283,8 +1288,6 @@ def test_exposed_globals_in_repl(self):
pre = "['__builtins__'"
post = "'__loader__', '__name__', '__package__', '__spec__']"
output, exit_code = self.run_repl(["sorted(dir())", "exit()"])
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
self.assertEqual(exit_code, 0)

# if `__main__` is not a file (impossible with pyrepl)
Expand Down Expand Up @@ -1347,9 +1350,6 @@ def _run_repl_globals_test(self, expectations, *, as_file=False, as_module=False
else:
self.fail("Choose one of as_file or as_module")

if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")

self.assertEqual(exit_code, 0)
for var, expected in expectations.items():
with self.subTest(var=var, expected=expected):
Expand Down Expand Up @@ -1497,8 +1497,6 @@ def test_correct_filename_in_syntaxerrors(self):
env = os.environ.copy()
commands = "a b c\nexit()\n"
output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
self.assertIn("SyntaxError: invalid syntax", output)
self.assertIn("<python-input-0>", output)
commands = " b\nexit()\n"
Expand Down Expand Up @@ -1526,8 +1524,6 @@ def test_proper_tracebacklimit(self):
with self.subTest(set_tracebacklimit=set_tracebacklimit,
basic_repl=basic_repl):
output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")
self.assertIn("in x1", output)
if set_tracebacklimit:
self.assertNotIn("in x2", output)
Expand Down Expand Up @@ -1569,8 +1565,6 @@ def test_history_survive_crash(self):
env = os.environ.copy()
commands = "1\nexit()\n"
output, exit_code = self.run_repl(commands, env=env)
if "can't use pyrepl" in output:
self.skipTest("pyrepl not available")

with tempfile.NamedTemporaryFile() as hfile:
env["PYTHON_HISTORY"] = hfile.name
Expand Down
Loading